[FFmpeg-devel] [PATCH] move QUANT_SHIFT #define to a sensible place

Diego Biurrun diego
Wed Nov 26 01:41:25 CET 2008


On Mon, Nov 24, 2008 at 04:26:53PM +0100, Michael Niedermayer wrote:
> On Mon, Nov 24, 2008 at 02:08:14PM +0100, Diego Biurrun wrote:
> > QUANT_SHIFT is only used in one function in h264.c, but it is hidden
> > somewhere between long tables in h264data.h.  This patch moves it to
> > h264.c.
> 
> both the table as well as the single function using it belong to our
> unfinished h264 encoder
> 
> also the values of the table are scaled by QUANT_SHIFT, thus the define
> does in some sense belong to the table

OK, alternative patch attached.  Anything else that should be moved to
the encoder?

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quant.diff
Type: text/x-diff
Size: 19858 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081126/e830adfa/attachment.diff>



More information about the ffmpeg-devel mailing list