[FFmpeg-devel] [PATCH] recover from truncated aiff

[Michael Niedermayer]

On Wed, Nov 26, 2008 at 01:21:59PM +0200, Maksym Veremeyenko wrote:
> Michael Niedermayer ???????(??):
> > On Wed, Nov 26, 2008 at 10:46:53AM +0200, Maksym Veremeyenko wrote:
> [...]
> >>      /* note: we need to modify the packet size here to handle the last
> >>         packet */
> >> -    pkt->size = ret;
> >> +    if((st->codec->block_align > 1) && (ret % st->codec->block_align)) {
> >> +        pkt->size -= pkt->size % st->codec->block_align;
> >> +        av_log(s, AV_LOG_WARNING, "truncated packet detected, dropped %d bytes\n", ret - pkt->size);
> >> +    }
> >> +
> >>      return ret;
> > 
> > iam against this patch, its not the job of the wav demuxer to truncate its
> > data
> According to that statement, all patches for wav, aiff and raw have no 
> sense? Am i correct?

iam not aiff maintainer, but i yes raw and wav look wrong


> 
> What method is preferable to fixing issue with truncated file contains 
> broken sample? Fixing pcm.c?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081126/d040169e/attachment.pgp>