[FFmpeg-devel] UDP multicasts mixed up on receive due to wrong bind()
Luca Abeni
lucabe72
Wed Nov 26 22:09:56 CET 2008
Jindrich Makovicka wrote:
> On Wed, Nov 12, 2008 at 14:15, Benoit Fouet <benoit.fouet at free.fr> wrote:
>> Le mercredi 12 novembre 2008 ? 09:52 +0100, Luca Abeni a ?crit :
>>> Just a minor nit:
>>> [...]
>>> + if (bind_ret < 0) {
>>> + if (bind(udp_fd,(struct sockaddr *)&my_addr, len) < 0)
>>> + goto fail;
>>> + }
>>> I think this should be applied without re-indenting the code, and
>>> re-indentation should be done in a second commit (also, the "{" and
>>> "}" are not needed, I think).
>>>
>> I'd even say it should be done in a single if()
>
> Ok, but this should be probably applied in one go.
Looks ok. Can be committed if it works reliably on Linux.
Thanks,
Luca
More information about the ffmpeg-devel
mailing list