[FFmpeg-devel] [PATCH] timestamp discontinuity in subtitles is OK

[Michael Niedermayer]

On Sun, Oct 05, 2008 at 02:17:19AM +0200, Michael Niedermayer wrote:
> On Sun, Oct 05, 2008 at 01:38:01AM +0200, Aurelien Jacobs wrote:
> > Hi,
> > 
> > ffmpeg.c contains some code to fix pts/dts when detecting timestamp
> > discontinuity. This is nice, but it really shouldn't care about
> > discontinuity in subtitle tracks, for obvious reason.
> > Attached patch disable discontinuity detection for subtitle tracks.
> 
> rejected

to elaborate before someone asks

subtitles have AVPacket.duration=0 that means unknown duration
and the discontinuity detection should test
last packet time + last packet duration vs. current paket time
thus if any of the 3 is unknown then the discontinuity detection
shouldnt even run.

Its obvious it is buggy, but a check for subtitles is not correct rather
the code should not detect discontinuities where it cannot.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081005/05a74cd0/attachment.pgp>