[FFmpeg-devel] [RFC] Channel layouts

[Diego Biurrun]

On Sun, Sep 07, 2008 at 08:58:28PM +1000, Peter Ross wrote:
> 
> Patch updated.
> 
> --- libavcodec/audioconvert.c	(revision 15246)
> +++ libavcodec/audioconvert.c	(working copy)
> @@ -71,6 +71,99 @@
>  
> +static const char* channel_names[]={
> +    "front-centre",
> +    "front-left-of-centre",
> +    "front-right-of-centre",
> +    "back-centre",
> +    "top-centre",
> +    "top-front-centre",
> +    "top-back-centre",

Please use American English spelling.

> --- libavcodec/avcodec.h	(revision 15246)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -355,6 +355,51 @@
>  
> +/* Audio channel masks */
> +#define CHANNEL_FRONT_CENTER           0x00000004
> +#define CHANNEL_FRONT_LEFT_OF_CENTER   0x00000040
> +#define CHANNEL_FRONT_RIGHT_OF_CENTER  0x00000080
> +#define CHANNEL_BACK_CENTER            0x00000100
> +#define CHANNEL_TOP_CENTER             0x00000800
> +#define CHANNEL_TOP_FRONT_CENTER       0x00002000
> +#define CHANNEL_TOP_BACK_CENTER        0x00010000

You already use American English spelling here...

Diego