[FFmpeg-devel] Review request - ra288.{c,h} ra144.{c,h}

[Benoit Fouet]

Vitor Sessak wrote:
> Benoit Fouet wrote:
>   
>> Hi,
>>
>> Vitor Sessak wrote:
>>     
>>> Vitor Sessak wrote:
>>>   
>>>       
>>>> Hi,
>>>>
>>>> Those four files never passed a review. I've just finished cleaning them 
>>>> up, so if anyone wants to review them (Michael already said he will), 
>>>> now is time.
>>>>     
>>>>         
>>> I think now they can go through another review cycle.
>>>
>>>   
>>>       
>> [from ra144.c]
>>     
>>> static void eval_coefs(int *coefs, const int *refl)
>>> {
>>>     int buffer[10];
>>>     int *b1 = buffer;
>>>     int *b2 = coefs;
>>>     int i, j;
>>>
>>>     for (i=0; i < 10; i++) {
>>>         b1[i] = refl[i] << 4;
>>>
>>>         for (j=0; j < i; j++)
>>>             b1[j] = ((refl[i] * b2[i-j-1]) >> 12) + b2[j];
>>>
>>>       
>> seems that will overwrite b1[i] affectation when j == 0
>>     
>
> Could you elaborate? For me, when j == 0
>
> b1[0] = ((refl[i] * b2[i-1]) >> 12) + b2[0];
>
> (and this will only be done when i != 0)
>
>   

indeed, I read a bit too quickly

-- 
Benoit Fouet
Purple Labs S.A.
www.purplelabs.com