[FFmpeg-devel] Brainfart cropping

[Jason Garrett-Glaser]

On Wed, Sep 10, 2008 at 3:39 PM, Jason Garrett-Glaser
<darkshikari at gmail.com> wrote:
> On Wed, Sep 10, 2008 at 12:59 PM, Jason Garrett-Glaser
> <darkshikari at gmail.com> wrote:
>> On Wed, Sep 10, 2008 at 12:58 PM, Jason Garrett-Glaser
>> <darkshikari at gmail.com> wrote:
>>>> the crop values are AFAIK in chroma samples, so 8 should be correct for 4:2:0
>>>> But it should be easy to check with the reference sw how much is cropped.
>>
>> Ah nevermind, you are right.  Which raises the question, of course,
>> why are we getting this message all over the place from x264-encoded
>> videos?
>
> And it appears the mistake is actually in x264, and nobody ever
> noticed because cropping is almost always handled on the container
> level, despite the mistake being there since the original commit to
> add support for non-mod16 in late 2005.

And, sorry to keep spamming the ML here, but it appears that I misread
the code... the x264 code is correct, it just moves the /2 to a
separate spot in the code, making it a bit harder to spot.  So this
problem is stlil unresolved.

Dark Shikari