[FFmpeg-devel] [PATCH] libx264: support for BUILD >= 63

[Stefano Sabatini]

On date Tuesday 2008-09-16 01:17:47 -0700, Jason Garrett-Glaser encoded:
> > While ifdeffery in libx264.c doesn't look like a good idea due to the
> > libx264 API instability, I think we could at least provide a check in
> > the configure script to disable libx264 if the detected version isn't
> > valid, looks nicer towards the user.
> 
> Bad idea--if the user explicitly enables something, and that thing
> fails, configure should fail outright, not disable it.  It does for
> all other external libs, so it should for x264, too.

Agree, so the check should fail.

> > And while we're at it we could assert(X264_BUILD == x264_build()) in
> > the init code (assuming that function is implemented).
> 
> Bad idea too; x264 can and does make API modifications that do not
> break backwards compatibility.

Yes but how can you tell? It may happen and it effectively happened at
least to one user on ffmpeg-user that he compiled with version X and
was loading an ABI incompatible version Y, which resulted in a crash.

Regards.
-- 
FFmpeg = Frenzy Fantastic MultiPurpose EnGine