[FFmpeg-devel] [PATCH] RealAudio SIPR @16k decoder (4/4) demuxer

[Michael Niedermayer]

On Wed, Sep 24, 2008 at 04:51:06PM +0200, Benjamin Larsson wrote:
> Hi.
> 
> 
> > Could you try the code with some damaged files? (created by tools/trasher or
> > some other tool)
> 
> I ran:
> 
> zzuf -c -r0.001:0.02 -s0:10000 -F5 -D0.5 -T60 -S ./ffmpeg -- -y -i
> intro.rm -acodec copy out.wav
> 
> (file from mphq)
> 
> And crashes started coming, none that I could relate to the extra code
> though.
> 

> ------------------------------------
> s=10
> wav_write_header
> av_log(s, AV_LOG_ERROR, "%s codec not supported in WAVE format\n",
>  s->streams[0]->codec->codec->name); with s->streams[0]->codec->codec
> being NULL
> 
> I removed the lookup and it ran better.

fixed


> ------------------------------------
> At s=85 it crashed on a division by zero, block_align was 0 cause of
> sub_packet_size corruption. Added a check for nozero block_size at the
> end of rm_read_audio_stream_info fixed it.

a clean fix is welcome, checking block_align==0 for all codecs is likely
going to break some ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080924/9e90328c/attachment.pgp>