[FFmpeg-devel] [Patch] fix mingw/faac linking

[Ramiro Polla]

On Thu, Sep 25, 2008 at 4:30 PM, Andrew Voznytsa
<andrew.voznytsa at gmail.com> wrote:
> On Thu, Sep 25, 2008 at 9:38 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
>
>>  "Andrew Voznytsa" <andrew.voznytsa at gmail.com> writes:
>>
>> > Oops - patch attached. Sorry.
>> >
>> > Thanks,
>> >
>> > Andrew
>> >
>> >
>> > Index: libavcodec/libfaac.c
>> > ===================================================================
>> > --- libavcodec/libfaac.c      (revision 15413)
>> > +++ libavcodec/libfaac.c      (working copy)
>> > @@ -25,6 +25,11 @@
>> >   */
>> >
>> >  #include "avcodec.h"
>> > +
>> > +#ifdef __MINGW32__
>> > +#define WIN32
>> > +#endif
>> > +
>> Rejected.
> Reason?

#ifdef'ing a specific system is not a good idea, since the system
might change at some other point in time, and FFmpeg minimizes the use
of such ifdefs.

Besides, I never got any problem with libfaac failing to link. What
version are you using? Is it compiled with mingw as well?

Ramiro Polla