[FFmpeg-devel] [Patch] fix mingw/faac linking

[Ramiro Polla]

Hi,

On Thu, Sep 25, 2008 at 5:51 PM, Dion Galbreath <DionG at viewcast.com> wrote:
> On Thu, Sep 25, 2008 at 4:30 PM, Andrew Voznytsa
> <andrew.voznytsa at gmail.com> wrote:
>> On Thu, Sep 25, 2008 at 9:38 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
>>
>>>  "Andrew Voznytsa" <andrew.voznytsa at gmail.com> writes:
>>>
>>> > Oops - patch attached. Sorry.
>>> >
>>> > Thanks,
>>> >
>>> > Andrew
>>> >
>>> >
>>> > Index: libavcodec/libfaac.c
>>> > ===================================================================
>>> > --- libavcodec/libfaac.c      (revision 15413)
>>> > +++ libavcodec/libfaac.c      (working copy)
>>> > @@ -25,6 +25,11 @@
>>> >   */
>>> >
>>> >  #include "avcodec.h"
>>> > +
>>> > +#ifdef __MINGW32__
>>> > +#define WIN32
>>> > +#endif
>>> > +
>>> Rejected.
>> Reason?
>
> #ifdef'ing a specific system is not a good idea, since the system
> might change at some other point in time, and FFmpeg minimizes the use
> of such ifdefs.
>
> Besides, I never got any problem with libfaac failing to link. What
> version are you using? Is it compiled with mingw as well?

[...]
> read ffmpeg-user and or libav-users there are a few people complaining.  I am using mingw32-gcc-4.2.1
> and it errs. I posted on one of those above news groups how to edit the h files for mingw users so they can get past the problems. There is with x264, and aac. But unfortunately mingw compilations get broken all the time.  Who's the maintainer so we can whip em into shape ;)
>
> :)
>
> Dion
>
>
> Here to be exact
>
> http://lists.mplayerhq.hu/pipermail/ffmpeg-user/2008-August/017007.html
> http://lists.mplayerhq.hu/pipermail/ffmpeg-user/2008-August/017008.html
>
>
> what is the preferred compiler to use cygwin or however you spell it? Or something else??
>
> Seems mingw doesn't get any love. Been a month and there still broken for mingw :)

I built FFmpeg (with no external libs) last week and regression tests
passed (even seek test, which used to fail due to a buggy printf in
older versions of Windows [1]).

I was setting up a test machine but very unfortunately Mike shut down
FATE [0] =(

If anyone knowledgeable in MinGW-FFmpeg volunteers to finish setting
up the test server, there is a spare AMD 64 machine sitting still at
home with a brand new install of Windows 2008 Server, MinGW and Python
and whatever else was needed to test FATE (yes, it was assembled with
this only purpose in mind).

Now I don't have any more free time to look at Windows issues and will
probably only look at them sometime in December.

Oh, and could you please use some other mail client besides Microsoft
Exchange? It doesn't wrap long lines and adds a big reply header at
the top of the message. These messages normally don't look good except
when read by some other Microsoft mailer. Thunderbird does the job
well and works well under Windows. Also trimming signatures and
removing long sequences of empty lines helps readability...

Ramiro Polla
[0] http://fate.multimedia.cx
[1] http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/67631