[FFmpeg-devel] [PATCH 4/4] Include stdlib.h to avoid an implicit declaration on OpenSolaris.

[Måns Rullgård]

Diego 'Flameeyes' Petten? <flameeyes at gmail.com> writes:

> While on GLIBC the memalign() function is declared in malloc.h, on
> OpenSolaris its definiton is in stdlib.h; include the file so that an
> implicit declaration can be avoided.
> ---
>
>  libavutil/mem.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/libavutil/mem.c b/libavutil/mem.c
> index 960074c..da75638 100644
> --- a/libavutil/mem.c
> +++ b/libavutil/mem.c
> @@ -34,6 +34,7 @@
>  #ifdef HAVE_MALLOC_H
>  #include <malloc.h>
>  #endif
> +#include <stdlib.h>
>
>  /* you can redefine av_malloc and av_free in your project to use your
>     memory allocator. You do not need to suppress this file because the

#including stdlib.h obviously can't do any harm, it being a standard
header.  There is, however, a deeper issue here: memalign() is not
defined by any standard, and some systems that have it provide no
means to free such allocations.  Is there any reason we can't use the
standard posix_memalign() instead?

-- 
M?ns Rullg?rd
mans at mansr.com