[FFmpeg-devel] [PATCH] MOV YUV2 fourcc -> PIX_FMT_YUYV422 mapping

[Michael Niedermayer]

On Wed, Apr 01, 2009 at 10:23:52AM +0530, Jai Menon wrote:
> On 3/31/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Mar 31, 2009 at 10:10:28AM +0530, Jai Menon wrote:
> >  > On Mon, Mar 30, 2009 at 11:01 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > [...]
> >  > revised patch attached.
> >  > --
> >  > Regards,
> >  >
> >  > Jai
> >
> >
> > > Index: libavcodec/rawenc.c
> >  > ===================================================================
> >  > --- libavcodec/rawenc.c       (revision 17944)
> >  > +++ libavcodec/rawenc.c       (working copy)
> >
> > > @@ -40,8 +40,20 @@
> >
> > >  static int raw_encode(AVCodecContext *avctx,
> >  >                              unsigned char *frame, int buf_size, void *data)
> >  >  {
> >  > -    return avpicture_layout((AVPicture *)data, avctx->pix_fmt, avctx->width,
> >  > +    int ret = avpicture_layout((AVPicture *)data, avctx->pix_fmt, avctx->width,
> >  >                                                 avctx->height, frame, buf_size);
> >  > +
> >
> >
> > > +    if(avctx->codec_tag == MKTAG('y', 'u', 'v', '2') && (ret > 0) &&
> >  > +       (avctx->pix_fmt == PIX_FMT_YUYV422)) {
> >
> >  superflous ()
> >  AV_RL32("yuv2")
> 
> removed ()s and using AV_RL32 now. requires #including intreadwrite.h
> though. for future reference, is this the way to go from now on for
> fourccs/tags etc?

where possible i guess yes

[...]
> revised patch attached.
[...]
> @@ -40,8 +41,20 @@
>  static int raw_encode(AVCodecContext *avctx,
>                              unsigned char *frame, int buf_size, void *data)
>  {
> -    return avpicture_layout((AVPicture *)data, avctx->pix_fmt, avctx->width,
> +    int ret = avpicture_layout((AVPicture *)data, avctx->pix_fmt, avctx->width,
>                                                 avctx->height, frame, buf_size);
> +
> +    if(avctx->codec_tag == AV_RL32("yuv2") && ret > 0 &&
> +       avctx->pix_fmt   == PIX_FMT_YUYV422) {
> +        int x, y;

> +        uint8_t *line = frame;

redundant 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090401/bb5e3680/attachment.pgp>