[FFmpeg-devel] [PATCH][VAAPI][4/6] Add MPEG-4 / H.263 bitstream decoding (take 10)

[Michael Niedermayer]

On Wed, Apr 01, 2009 at 11:39:22AM +0200, Gwenole Beauchesne wrote:
> On Tue, 31 Mar 2009, Michael Niedermayer wrote:
>
>>>> I fail to see a difference with the very few samples I have
>>>> but that covers only the H.263 samples from mpq and I did not find any 
>>>> for
>>>> !short-header case. i.e. I just can't say this will really work for all
>>>> samples.
>>
>> you found no mpeg4 asp, no divx no xvid on mphq?
>
> mpeg4 asp that has binary-only shape.

they are stored where the scaleable mpeg2 files are, in
/mpegs_sick_dreams_that_luckily_didnt_come_true
;)


>
>>> Changed the last line to:
>>> pic_param->num_gobs_in_vop = (s->mb_width * s->mb_height) /
>>> pic_param->num_macroblocks_in_gob;
>>> which should be more abvious than the previous "simplification".
>>>
>>> Only tested with 352x288 clips, did not find any larger ones.
>>
>> ffmpeg can create larger ones, also ffmpeg can make mpeg4 asp
>> you also should find some after running the regression tests
>
> ffmpeg couldn't with some abbreviated names, though explicit sizes worked. 
> ;-)
>
> OK, checked against all VA API (Intel implementation) supported CIF, and 
> this yields the correct values for all of them.
>
> New patch attached.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090401/a875e1e4/attachment.pgp>