[FFmpeg-devel] [PATCH] fix r18319

Alex Converse alex.converse
Fri Apr 3 15:49:33 CEST 2009


On Fri, Apr 3, 2009 at 8:50 AM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> Hello,
> several fixes to be applied separately:
> 1) ff_vector128 is only used locally and via MANGLE, so it should use
> DECLARE_ASM_CONST
> 2) all output operands are written before we finished using the input
> operands so they must be early-clobber (&)
> 3) using av_uninit is a horrible hack instead the correct =& asm
> constraint should have been used. I'd like to remind everyone to _think_
> and think again before using av_uninit, it is _only_ for working around
> when the compiler is wrong, not to hide that your code is broken!
>

Looks good to me. Sorry about the delay. It was overnight in my timezone.



More information about the ffmpeg-devel mailing list