[FFmpeg-devel] Google Summer of Code participation

[Michael Niedermayer]

On Sun, Apr 05, 2009 at 12:59:58AM +0200, Thilo Borgmann wrote:
>
>
> Michael Niedermayer schrieb:
>>> diff --git a/libavcodec/qcelpdec.c b/libavcodec/qcelpdec.c
>>> index 32e74a6..3cdfc08 100644
>>> --- a/libavcodec/qcelpdec.c
>>> +++ b/libavcodec/qcelpdec.c
>>> @@ -586,7 +586,7 @@ static void apply_pitch_filters(QCELPContext *q, 
>>> float *cdn_vector)
>>>   *
>>>   * TIA/EIA/IS-733 2.4.3.3.5
>>>   */
>>> -static void lspf2lpc(const float *lspf, float *lpc)
>>> +void lspf2lpc(const float *lspf, float *lpc)
>>>  {
>>>      double lsf[10];
>>>      double bandwith_expansion_coeff = QCELP_BANDWITH_EXPANSION_COEFF;
>>>     
>>
>> ehh?
>>
>>   
> Mysterious... somehow this file got out of sync on my local copy. As I 
> think that there were more decoder files edited since I'm working on these 
> I wonder why this is the only one (I had another look at the rev4 patch for 
> similar occurances, none found)...
>
> I think I've mixed it up with git somehow, I'm sorry and new to git. As I 
> said, there should not be another problem of that kind within revision 5. 
> I've cloned into another directory and applied my two patches (movedAgain & 
> rev5) and it compiles and tests. Also, the patch itself looks good.
>
> TB

[...]
> diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> index 4113382..68c4597 100644
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -524,18 +524,31 @@ int avcodec_encode_subtitle(AVCodecContext *avctx, uint8_t *buf, int buf_size,
>      return ret;
>  }
>  
> +#if LIBAVCODEC_VERSION_MAJOR < 53
>  int attribute_align_arg avcodec_decode_video(AVCodecContext *avctx, AVFrame *picture,
>                           int *got_picture_ptr,
>                           const uint8_t *buf, int buf_size)
>  {
> +    AVPacket avpkt;
> +    avpkt.data = buf;
> +    avpkt.size = buf_size;
> +

This leaves many fields uninitialized


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090405/f620a611/attachment.pgp>