[FFmpeg-devel] [PATCH] g722 decoder, no licensing fame

[Kenan Gillet]

On Apr 5, 2009, at 3:37 AM, Diego Biurrun wrote:

> On Sat, Apr 04, 2009 at 03:40:13PM -0700, Kenan Gillet wrote:
>>
>> --- libavcodec/g722.c	(revision 0)
>> +++ libavcodec/g722.c	(revision 0)
>> @@ -0,0 +1,349 @@
>> +
>> +/**
>> + * @file libavcodec/g722dec.c
>> + *
>> + * G.722 ADPCM audio codec
>> + *
>> + * This G.722 decoder is a bit exact implementation of the ITU G. 
>> 722 specification
>
> bit-exact

done


>
>> + * for all three specified bit rates - 64000bps, 56000bps and  
>> 48000bps.
>
> bitrates

done

>
>> +/**
>> + * quadrature mirror filters (QMF) coefficients
>
> filter

done


>
>> +    if(cur_diff) {
>
> if (

done


>
>> +static void update_low_predictor(struct G722Band *band, const int  
>> ilow) {
>
> Please consistently use K&R function declarations, i.e. place the { on
> the next line, same below.

done

>
>> +static int g722_encode_frame(AVCodecContext *avctx,
>> +                            uint8_t *dst, int buf_size, void *data)
>
> The indentation is off.

done


>> +    for (j = 0;  j < buf_size;  ) {
>
> stray space before (
>

done


>> +#endif
>> \ No newline at end of file
>
> Fix this.
>
> Documentation and build system parts are OK.

done

thanks for the review

Kenan