[FFmpeg-devel] Google Summer of Code participation
Thilo Borgmann
thilo.borgmann
Thu Apr 9 20:00:02 CEST 2009
Michael Niedermayer schrieb:
>
>> for(j=0; j<width*s->bpp; j++)
>>
>
> yes
>
>
Done.
>
>> Which is fail safe if s->bit_depth != 8.
>> If you realy want width*3 then there has to be something I don't
>> understand. If that's the case, please tell me why "3" will always work...
>>
>>>> @@ -602,8 +632,10 @@ static int decode_frame(AVCodecContext *avctx,
>>>> static av_cold int png_dec_init(AVCodecContext *avctx){
>>>> PNGDecContext *s = avctx->priv_data;
>>>> - avcodec_get_frame_defaults(&s->picture);
>>>> - avctx->coded_frame= &s->picture;
>>>> + s->current_picture = &s->picture1;
>>>> + s->last_picture = &s->picture2;
>>>> + avcodec_get_frame_defaults(&s->picture1);
>>>>
>>>>
>>>
>>>
>>>> + avctx->coded_frame= &s->picture1;
>>>>
>>>>
>>> this is wrong
>>>
>>>
>>>
>> I carried it over from the original code. Although it can be deleted
>> completely, it might be set "avctx->coded_frame = &s->picture2" to respect
>> the initial flip in decode frame and thus keep close to the original. If
>> not, what is wrong?
>>
>
> it should point to the current frame not to every second frame
>
Also done.
I've attached revision 2.
TB
More information about the ffmpeg-devel
mailing list