[FFmpeg-devel] [PATCH] API changes in ffmpeg.c
Thilo Borgmann
thilo.borgmann
Fri Apr 10 13:55:52 CEST 2009
Ok a new thread for the API changes in ffmpeg.c, cut off from the
original thread:
Stefano Sabatini schrieb:
> On date Wednesday 2009-04-08 16:09:01 +0200, Thilo Borgmann encoded:
> [...]
>
>> diff --git a/ffmpeg.c b/ffmpeg.c
>> index cb15120..4944811 100644
>> --- a/ffmpeg.c
>> +++ b/ffmpeg.c
>> ...
>> - ptr += ret;
>> - len -= ret;
>> + avpkt.data += ret;
>> + avpkt.size -= ret;
>> /* Some bug in mpeg audio decoder gives */
>> /* data_size < 0, it seems they are overflows */
>> if (data_size <= 0) {
>> @@ -1245,8 +1247,8 @@ static int output_packet(AVInputStream *ist, int ist_index,
>> /* XXX: allocate picture correctly */
>> avcodec_get_frame_defaults(&picture);
>>
>> - ret = avcodec_decode_video(ist->st->codec,
>> - &picture, &got_picture, ptr, len);
>> + ret = avcodec_decode_video2(ist->st->codec,
>> + &picture, &got_picture, pkt);
>>
>
> Crash here.
>
> Make sure you test your patches with make test before to submit them.
>
> Also please one thread per patch, that should make easier the review
> and commit process.
>
> Regards.
>
Crash fixed, revision 1 of the patch attached. More comments on this
already posted in the originating thread.
TB
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tb.APICallsInFFmpeg.rev1.patch
Type: text/x-patch
Size: 4590 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090410/e7e08185/attachment.bin>
More information about the ffmpeg-devel
mailing list