[FFmpeg-devel] [PATCH] API changes in ffmpeg.c

[Michael Niedermayer]

On Fri, Apr 10, 2009 at 08:29:25PM +0200, Thilo Borgmann wrote:
> Michael Niedermayer schrieb:
>>   
>>>>>            &picture, &got_picture, ptr, len);
>>>>> +                    ret = avcodec_decode_video2(ist->st->codec,
>>>>> +                                               &picture, &got_picture, 
>>>>> pkt);
>>>>>             
>>>> Crash here.
>>>>         
>>> This is revision 1 which fixes the crash during make test.
>>>     
>>
>> probably ok if tested
>>
>>   
> Although applied, I tested it again using ffmpeg for transcoding the 
> corepng.avi into yuv format.
>
> This revealed a bug in my ffmpeg.c patch, but this bug breaks CorePNG 
> decoding only, since this is the only one using more information of the 
> provided packet than .data and .size attributes.
>
> FFplay is not broken as it uses no local AVPackets but the "original" one.
>
> I attached a little patch for the time being, but I would propose to add a 
> "av_copy_packet" function into libavcodec/avpacket.c as future codecs will 
> also use more attributes of the avpacket and even others than just the 
> .flags attribute.

patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090410/18543868/attachment.pgp>