[FFmpeg-devel] maintainer duties (was: Re: [PATCH] fix speex sample)

[Diego Biurrun]

On Sat, Apr 11, 2009 at 05:48:07AM +0200, Michael Niedermayer wrote:
> On Sat, Apr 11, 2009 at 03:42:04AM +0200, Diego Biurrun wrote:
> > On Fri, Apr 10, 2009 at 10:48:36PM +0200, Michael Niedermayer wrote:
> > > On Fri, Apr 10, 2009 at 09:01:36PM +0200, Diego Biurrun wrote:
> > > > On Fri, Apr 10, 2009 at 08:45:41PM +0200, Michael Niedermayer wrote:
> > > > > 
> > > > > Was there a function i deprecated but did not replace where a trivial
> > > > > search and replace was sufficient?
> > > > 
> > > > Did any of them require considerable amounts of work?  I don't think so.
> > > 
> > > let me repeat my question, what are you talking about?
> > > Its very obvious you dont want the issues (if they even exist) fixed
> > > because otherwise you would have pointed to them by now
> > 
> > I have already pointed the functions out:
> > 
> > http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2009-March/065629.html
> 
> but this is what i meant, its either things that have alraedy been fixed
> or things that are non trivial to fix.
> you said above
> "Did any of them require considerable amounts of work?  I don't think so."
> 
> Whats left from this list needs considerable amounts of work
> 
> lets see whats in that list:
> 
> > Michael:
> > libavformat/asfdec.c:364: warning: AVPaletteControl is deprecated
> > libavformat/avidec.c:491: warning: AVPaletteControl is deprecated
> 
> we first need to decide how to put the palette info into the bitstream, also
> fixing these 2 will require all decoders that support palettes from avi/asf
> to be fixed at the same time as well.

If this has not been decided, why is the function deprecated?  There
should be a proper replacement first...

> > libavutil/random.h:55: warning: av_random_generate_untempered_numbers is deprecated (declared at libavutil/random.h:39)
> > libavutil/random.h:73: warning: av_random is deprecated (declared at libavutil/random.h:50)
> > libavutil/random.h:55: warning: av_random_generate_untempered_numbers is deprecated (declared at libavutil/random.h:39)
> > libavutil/random.h:73: warning: av_random is deprecated (declared at libavutil/random.h:50)
> 
> these have been fixed already, and iam sorry that i did not do more
> of these fixes myself, but i dont really remember anyone asking me to
> and what you putted under my name was nonsense not fixable, as the whole
> file should and was removed once it became unused.
> You did not list the actual uses of av_random() that occured all over the
> place under my name ...

av_random() is now history thanks to my efforts.

> > Remaining deprecated functions are AVPaletteControl and ff_realloc_static,
> > the latter is only used once even...
> 
> its used just once but to fix this each use of init_vlc() has to be changed
> and in some cases in non trivial ways
> I fixed some of these init_vlc cases, i did not fix all.
> I was hoping the respective maintainers of the files would help ...

Why did you not request the maintainers to fix their code?

> a grep INIT_VLC_USE_STATIC will show some of what need to be changed
> but there are more init_vlc that just pass 1 instead of INIT_VLC_USE_STATIC
> a
> grep -A4 init_vlc libavcodec/*.c | grep '1 *)'
> might catch some more ...

I think Carl Eugen just sent a patch for this.

> So next time you accuse me (and i am sure you will because it seems to be
> poplar and the more polite i awnser the more people do)
> maybe you should read and understand the code over which it is first.

What I want you to do is give proper attention to these matters and not
leave them half-done.  When a function is deprecated, whomever creates
the replacement should fix up the deprecated uses or coordinate efforts
to get those uses replaced by maintainers or kindred spirits.

Note that I managed to do it for rand() and friends, _t POSIX namespace
pollution and a few more things, so it's not like I do not put effort
into these issues.

Diego