[FFmpeg-devel] [PATCH] Document ff_put_string()

[Michael Niedermayer]

On Sat, Apr 11, 2009 at 10:42:15AM +0200, Stefano Sabatini wrote:
> On date Friday 2009-04-10 19:09:04 +0200, Michael Niedermayer encoded:
> > On Fri, Apr 10, 2009 at 06:09:41PM +0200, Stefano Sabatini wrote:
> > > Hi,
> > > as in subject.
> > > -- 
> > > FFmpeg = Fast & Funny Mastodontic Portentous Erotic Generator
> > 
> > > Index: ffmpeg/libavcodec/bitstream.h
> > > ===================================================================
> > > --- ffmpeg.orig/libavcodec/bitstream.h	2009-04-10 18:05:29.000000000 +0200
> > > +++ ffmpeg/libavcodec/bitstream.h	2009-04-10 18:07:21.000000000 +0200
> > > @@ -159,6 +159,13 @@
> > >   * Pads the bitstream with zeros up to the next byte boundary.
> > >   */
> > >  void put_bits_align(PutBitContext *s);
> > > +
> > > +/**
> > > + * Puts the string \p s in the bitstream.
> > > + *
> > 
> > > + * @param put_zero if non-zero puts in the bitstream the terminating
> > > + * character
> > 
> > well ok after reading it twice it makes sense but maybe you could change
> > this so it makes sense on the first pass?
> 
> Second try attached.
> 
> Regards.
> -- 
> FFmpeg = Frenzy and Foolish Mysterious Pitiless Entertaining Game

> Index: ffmpeg/libavcodec/bitstream.h
> ===================================================================
> --- ffmpeg.orig/libavcodec/bitstream.h	2009-04-11 10:21:03.000000000 +0200
> +++ ffmpeg/libavcodec/bitstream.h	2009-04-11 10:40:20.000000000 +0200
> @@ -159,6 +159,13 @@
>   * Pads the bitstream with zeros up to the next byte boundary.
>   */
>  void align_put_bits(PutBitContext *s);
> +
> +/**
> + * Puts the string \p s in the bitstream.
> + *

> + * @param put_zero if non-zero [...]

still same issue

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090411/ef0601b5/attachment.pgp>