[FFmpeg-devel] maintainer duties (was: Re: [PATCH] fix speex sample)

[Michael Niedermayer]

On Sat, Apr 11, 2009 at 03:36:39PM +0200, Reimar D?ffinger wrote:
> On Sat, Apr 11, 2009 at 09:23:49AM -0400, Ronald S. Bultje wrote:
> > On Sat, Apr 11, 2009 at 7:49 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > > It has been decided to put the palette in the AVPackets
> > > how to do this is a question per decoder and per demuxer, some may have a
> > > natural way to pass the palette, some might even say in a spec how to do it
> > > (though i guess that would be the exception if it applies to any at all)
> > > the rest could just have a 'P'<len> vs. 'D' prefixed to packets
> > 
> > I think I said this before, I don't like this (conceptually). Can't we
> > just add a PKT_FLAG_PALETTE? It's exactly the same as a prefix, except
> > that it does not actually touch the bitstream. Now that Thilo added
> > all these AVPackets to the decode() functions, let's use them.
> 
> It does not solve remuxing into containers that do not support separate
> palette packets.
> It also does not solve the case of e.g. ipmovie.c where a "palette
> packet" is allowed to change a single palette entry, unless you want to
> allow PKT_FLAG_PALETTE packets to contain anything they want the demuxer
> would still have to keep a copy of the palette around, modify it and
> send the full palette on. Not only is that something a demuxer IMO
> should not do, but it also loses information and can bloat the size a
> lot.

> Also I think it would already be quite simple to fix if we just allowed
> packets to contain only palette (without any PKT_FLAG_PALETTE), since
> allocating a buffer and merging the palette stuff together with a video
> buffer is just a pain to implement. The problem though is that no
> keyframes at all would exist then.

i think palette belongs in the packet with a frame not in a seperate packet
a palette is like a quantization tables in mpeg, we should treat it like
one


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090411/a421aa9a/attachment.pgp>