[FFmpeg-devel] [PATCH] QCELP decoder postfilter & final gain control

[Måns Rullgård]

"Reynaldo H. Verdejo Pinochet" <reynaldo at opendot.cl> writes:

> Hi
>
> M?ns Rullg?rd wrote:
>> 
>> Merely calculating an address outside an array or dynamically
>> allocated block might cause an overflow trap or similar.  I have seen
>> this happen in a real system, and it was not easy to track it down.
>
> That's what I feared but had no practical proof on that regard. I
> also think that even while not absolutely sure them would fail these
> borderline, syntactical 'tricks' aren't generally worth their risk.
>
> Kenan, would you please update your patch accordingly? While you
> are at it I will fix the outstanding occurrences of this in the
> celp code.

In this particular case, the trick can be made safe simply by
allocating one extra element at the start of the array.

-- 
M?ns Rullg?rd
mans at mansr.com