[FFmpeg-devel] [PATCH] RTSP-MS 14/15: ASF packet parsing

[Michael Niedermayer]

On Sat, Apr 18, 2009 at 02:40:31PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Apr 18, 2009 at 1:57 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > no
> 
> Oops, sorry. That last hack is still (only one this time) necessary, I
> was hoping to get to that next...
[...]

> Index: ffmpeg-svn/libavformat/asfdec.c
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/asfdec.c	2009-04-17 10:11:28.000000000 -0400
> +++ ffmpeg-svn/libavformat/asfdec.c	2009-04-18 10:24:43.000000000 -0400
> @@ -572,6 +572,8 @@
>      if (c != 0x82) {
>          if (!url_feof(pb))
>              av_log(s, AV_LOG_ERROR, "ff asf bad header %x  at:%"PRId64"\n", c, url_ftell(pb));
> +        else
> +            return AVERROR_EOF;
>      }
>      if ((c & 0x8f) == 0x82) {
>          if (d || e) {

this was and is unacceptable
to the 4th time, you cannot place a if(rtp) check in the asf demuxer.
and it is a rtp check because url_feof() will not evaluate to 1 after
each packet.

again, simple check, store all packets in a file, try to play it, try to
seek.
If it fails, your patchset is incomplete, and it WILL fail because the
written file will not have url_feof() == 1 after each packet


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090418/ed8208dd/attachment.pgp>