[FFmpeg-devel] Suggestion for a centralized language-tag facility in libavformat

[cyril comparon]

>> Sure thing. I wrote it using Qt4. Please find it attached
>> (iso639tool.cpp, iso639tool.pro, iso639tool.readme).
> there seem to be only 2 patches attached

Oops, forgot to attach them. Here they are.

>
> I also found no hint in the spec that would restrict what key can be, and
> IMHO it can be anything including NULL
>

I got rid of the temporary key object and I changed the comparison
function to interpret its lhs arg directly as a const char* ; it seems
to work properly with my tests but I am not sure this will work with
all stdlib implementations...

>> + ? ? ? ? ? ?stream_language_index = asf->streams[i].stream_language_index;
>> + ? ? ? ? ? ?rfc1766 = asf->stream_languages[stream_language_index];
>
> this still reads outside the array

I think I got messed up with my different patch versions...

Thanks for your time
Cyril
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iso639tool.cpp
Type: application/octet-stream
Size: 5070 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090422/7bf8f634/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iso639tool.pro
Type: application/octet-stream
Size: 90 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090422/7bf8f634/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iso639tool.readme
Type: application/octet-stream
Size: 622 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090422/7bf8f634/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_avlanguage-a.patch
Type: application/octet-stream
Size: 26964 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090422/7bf8f634/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_asf_languages-a.patch
Type: application/octet-stream
Size: 9624 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090422/7bf8f634/attachment-0004.obj>