[FFmpeg-devel] [PATCH] asf*.c/h: use AVFormatContext->packet_size instead of own copy

[Ronald S. Bultje]

Hi,

On Wed, Apr 22, 2009 at 10:57 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Apr 22, 2009 at 10:42:40AM -0400, Ronald S. Bultje wrote:
>> On Wed, Apr 22, 2009 at 10:02 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > changing the packet_size to signed is rejected
>>
>> What if I make AVFormatContext->packet_size unsigned? Seems like it's
>> always incorrect.
>
> that could be considered

Before I make myself look stupid and submit the obvious patch, could
you elaborate on the considerations that I should attach to your
"could"? We're not changing any alignment by adding an unsigned, but
technically we are sort of breaking "ABI" because we change the
meaning of <0 (from undefined/invalid to big). That needs no version
bump, right?

Ronald