[FFmpeg-devel] [PATCH] Fix monoblack pixdesc shift

[Stefano Sabatini]

On date Saturday 2009-04-25 14:03:39 +0200, Michael Niedermayer encoded:
> On Sat, Apr 25, 2009 at 09:50:07AM +0200, Stefano Sabatini wrote:
> > On date Friday 2009-04-24 02:21:11 +0200, Michael Niedermayer encoded:
> > > On Fri, Apr 24, 2009 at 02:02:29AM +0200, Stefano Sabatini wrote:
> > > > On date Friday 2009-04-24 01:40:46 +0200, Michael Niedermayer encoded:
> > > > > On Thu, Apr 23, 2009 at 11:58:22PM +0200, Stefano Sabatini wrote:
> > > > > > Hi, as in subject. Regards.
> > > > > 
> > > > > I thought you tested your get_bits() replacement?
> > > > 
> > > > No it makes no difference since shift is not used for bitstream
> > > > formats, but it looks weird anyway.
> > > 
> > > if its not used the patch is useless
> > 
> > Still may be useful to the reader, having a non-used field set to 7
> > does not help understanding that it is unused.
> 
> setting it to UNUSED and #define that to something would be clear but it
> would mess up the vertical alignment

What about this?

Regards.
-- 
FFmpeg = Fierce and Friendly Mastodontic Programmable Exploitable Glue
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pixdesc-shift-cosmetics.patch
Type: text/x-diff
Size: 1710 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090425/0bf7d4ef/attachment.patch>