[FFmpeg-devel] [PATCH] Set correct frame_size for Speex decoding

[Michael Niedermayer]

On Fri, Jul 31, 2009 at 06:48:59PM -0400, Justin Ruggles wrote:
> Michael Niedermayer wrote:
> > On Thu, Jul 30, 2009 at 07:25:17PM -0400, Justin Ruggles wrote:
> >> Justin Ruggles wrote:
> >>> Hi,
> >>>
> >>> Currently AVCodecContext.frame_size is not set correctly for Speex.
> >>> Since the Ogg and FLV demuxers and the libspeex decoder handle a full
> >>> packet as a single frame, frame_size should be set to the Speex
> >>> frame_size * frames_per_packet.
> >>>
> >>> If frames_per_packet is not specified in the Speex header, or if there
> >>> is no header, it can be determined after decoding the first packet.
> >>>
> >>> Stream copy is not implemented yet for Speex, but once it is, a parser
> >>> will be able to set all the stream parameters instead of the decoder
> >>> when the header is missing or incomplete.
> >> ping.
> > 
> > it might be helpfull if you say who you expect to review this
> 
> In general, I'm looking for an ok on having lavf and lavc treat a whole
> Speex packet as a single frame.  After considering and trying to code
> the split-then-join idea it did not seem like a very clean solution, and
> it is not really necessary.  This is my general plan:

which values of frames_per_packet does each container allow?
that is each container that supports speex

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090801/b9d82019/attachment.pgp>