[FFmpeg-devel] [PATCH] TwinVQ decoder

[Vitor Sessak]

Reimar D?ffinger wrote:
> On Sun, Aug 02, 2009 at 06:25:16PM +0200, Vitor Sessak wrote:
>>>>     init_get_bits(&gb, buf, buf_size * 8);
>> Oops, I completely forgot that. Fortunately it is pretty trivial for  
>> twinvq (the number of bits per frame is fixed). Done.
> 
> I guess it is not useful/easily done to support partial frames?

The only case I see in the wild of partial frames is the last frame of 
truncated files. I don't think it is worth the trouble.

> I think I have no further comments right now, except a bit about
> the indentation etc., particularly the ModeTab stuff IMO would be
> nicer with proper indentation, even if it leaves the lines around
> 100 characters long...

Great, thanks for the review. I've attached a new version with some 
indentation changes. Michael, ok to commit?

-Vitor

PS @Diego: Now with build and documentation changes...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: twin.diff
Type: text/x-diff
Size: 1882 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090802/1ab15225/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: twinvq.c
Type: text/x-csrc
Size: 39414 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090802/1ab15225/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: twinvq_data.h
Type: text/x-chdr
Size: 13509 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090802/1ab15225/attachment.h>