[FFmpeg-devel] [PATCH] Wave64 demuxer

[Reimar Döffinger]

On Fri, Aug 07, 2009 at 01:10:31PM -0400, Daniel Verkamp wrote:
> +        url_fskip(pb, (size + 7) & ~INT64_C(7));

If FFALIGN doesn't work for this it should maybe be changed...

> +    size = av_get_packet(s->pb, pkt, FFMIN(size, left));
> +    if (size <= 0)
> +        return AVERROR(EIO);

IMO
if (size < 0)
    return size;

is better.

> +    pkt->size         = size;

Huh? That's useless, av_get_packet sets it right.
But this whole thing looks a lot like a normal wav file just with
some extension, are you sure this should be a completely new demuxer
instead of an extension to the "normal" one?