[FFmpeg-devel] [PATCH] Wave64 demuxer

Diego Biurrun diego
Sat Aug 8 12:18:49 CEST 2009


On Sat, Aug 08, 2009 at 04:13:17AM -0400, Daniel Verkamp wrote:
> On Sat, Aug 8, 2009 at 2:49 AM, Reimar
> D?ffinger<Reimar.Doeffinger at gmx.de> wrote:
> > On Sat, Aug 08, 2009 at 02:09:26AM +0200, Michael Niedermayer wrote:
> >> > >> @@ -209,6 +306,11 @@ static int wav_read_packet(AVFormatContext *s,
> >> > >>
> >> > >> ? ? ?left= wav->data_end - url_ftell(s->pb);
> >> > >> ? ? ?if(left <= 0){
> >> > >> +#if CONFIG_W64_DEMUXER
> >> > >> + ? ? ? ?if (wav->w64) {
> >> > >
> >> > > if(CONFIG_W64_DEMUXER && wav->w64) {
> >> > >
> >> >
> >> > Ok... (does this actually work with all supported compilers?)
> >>
> >> apparently ... if it fails such code would of course need to be replaced
> >>
> >> and patch ok unless reimar has more comments
> >
> > I was too fast: I actually have one comment:
> > I'd still like to have a sample file for this format in the samples
> > collection...
> 
> There are some samples here: http://multimedia.cx/libsndfile-samples/

Now available at http://samples.ffmpeg.org/A-codecs/libsndfile-samples/

> Fixed from previous patch: possible infinite loop in find_guid,
> incorrect math when skipping header in read_packet.

Documentation and changelog updates are missing.

Diego



More information about the ffmpeg-devel mailing list