[FFmpeg-devel] [PATCH] Misc. tag handling related patches

Matti Hamalainen mhamalai
Sun Aug 9 10:43:48 CEST 2009


A bunch of patches mostly related to improving APE tag handling.
Included fixes are based on my own tests and Hydrogenaudio's wiki-page
http://wiki.hydrogenaudio.org/index.php?title=APEv2_specification

Most of these need to be applied in (following) order:

1) fix-ape-tag-size-adjustment.patch
Remove incorrect tag size adjustment based on flags, the size already
includes the whole tag, including footer.

2) fix-ape-tag-key-handling.patch
Fix broken APE tag key handling and use get_byte instead of dangerously
fiddling with the ByteIOContext buffer directly without bounds checking.
Also add return value to ape_tag_read_field() and break on reading further
tag fields if one fails.

3) improve-ape-tag-handling.patch
Try to handle different placements of APE tags better, including those 
placed at file beginning.

4) separate-ape-tag-handling.patch
This is a big one, and adds two new files:

Move APE tag handling to apetag.[ch] and add ff_-prefix to 
ape_parse_tag().

5) musepack-sv7-ape-tag-support.patch
Add APE tag metadata reading support in Musepack SV7 demuxer.

6) musepack-sv7-id3v2-tag-support.patch
Add parsing of ID3v2 tags in Musepack SV7 demuxer.
(This does not actually depend on previous patches.)

-- 
] ccr/TNSP^DKD^pWp  :: ccr tnsp org ::  http://ccr.tnsp.org/
] PGP key: 0466 95ED 96DF 3701 C71D D62D 10A6 28A6 1374 C112
-------------- next part --------------
A non-text attachment was scrubbed...
Name: musepack-sv7-id3v2-tag-support.patch
Type: text/x-diff
Size: 1761 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/c5754712/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: musepack-sv7-ape-tag-support.patch
Type: text/x-diff
Size: 1567 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/c5754712/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: separate-ape-tag-handling.patch
Type: text/x-diff
Size: 11116 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/c5754712/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: improve-ape-tag-handling.patch
Type: text/x-diff
Size: 1833 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/c5754712/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-ape-tag-key-handling.patch
Type: text/x-diff
Size: 2155 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/c5754712/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-ape-tag-size-adjustment.patch
Type: text/x-diff
Size: 673 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/c5754712/attachment-0005.patch>



More information about the ffmpeg-devel mailing list