[FFmpeg-devel] [PATCH] fix darwin EBX check in configure

[Måns Rullgård]

Alexander Strange <astrange at ithinksw.com> writes:

> check_as uses ASFLAGS instead of CFLAGS, and -mdynamic-no-pic (which
> makes EBX available) is only in CFLAGS, so the test fails.
> This adds it to ASFLAGS too. Of course, on darwin ASFLAGS isn't even
> used for anything except check_as, but other fixes seemed like they
> might break something else.
>
> Note that -mdynamic-no-pic works fine with shared libraries with a
> recent linker, but prints 6500+ warnings about textrels.
>
>
> Index: configure
> ===================================================================
> --- configure	(revision 19609)
> +++ configure	(working copy)
> @@ -1871,7 +1871,15 @@
>          FFSERVERLDFLAGS=-Wl,-bind_at_load
>          objformat="macho"
>          enabled x86_64 && objformat="macho64"
> -        enabled shared || check_cflags -mdynamic-no-pic
> +        if ! enabled shared; then
> +            check_cc -mdynamic-no-pic <<EOF
> +            int x;
> +EOF
> +            if test "$?" == 0; then
> +                add_cflags -mdynamic-no-pic
> +                add_asflags -mdynamic-no-pic
> +            fi
> +        fi

enabled shared ||
    { check_cflags -mdynamic-no-pic && add_asflags -mdynamic-no-pic; }

-- 
M?ns Rullg?rd
mans at mansr.com