[FFmpeg-devel] [PATCH] Psygnosis YOP demuxer

[Thomas Higdon]

On Sun, Aug 9, 2009 at 10:01 AM, compn<tempn at twmi.rr.com> wrote:
> On Sun, 9 Aug 2009 03:10:36 -0400, Thomas Higdon wrote:
>>[yop-demux.diff ?text/x-patch (8.2KB)]
>>Index: Changelog
>>===================================================================
>>--- Changelog ?(revision 19609)
>>+++ Changelog ?(working copy)
>>@@ -4,6 +4,7 @@
>>
>> version <next>:
>>
>>+- Add Psygnosis YOP demuxer
>> - PB-frame decoding for H.263
>> - deprecated vhook subsystem removed
>> - deprecated old scaler removed
>
> new changes go to the bottom of the top-most group
>
> new version
> ?oldest feature
> ?older feature
> ?old feature
> ?new feature
> ?newer feature
> ?newest feature
>
> old version
> ...

Fixed.

>>+ ? ?/* The Westwood IMA ADPCM decoder is compatible with the with the YOP
>>+ ? ? * audio. */
>
> unneeded comment

Fixed.

>>+#define YOP_SIGNATURE "YO"
>>+#define YOP_AUDIO_SAMPLE_RATE (22050)
>>+#define YOP_AUDIO_SAMPLES_PER_FRAME (1840)
>>+#define YOP_AUDIO_NUM_CHANNELS (1)
>>+
>>+#define YOP_SECTOR_SIZE (2048)
>
> unneeded parentheses

Just a habit I've gotten into because if macros contain expressions,
hard-to-debug errors
related to order of operations can show up. They're obviously not
necessary in this case, and are removed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: yop-demux.diff
Type: text/x-patch
Size: 8254 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/4f637f54/attachment.bin>