[FFmpeg-devel] [PATCH] 6/6 Add parsing of ID3v2 tags in Musepack SV7 demuxer.

Kostya kostya.shishkov
Tue Aug 11 19:29:10 CEST 2009


On Mon, Aug 10, 2009 at 09:51:57PM +0300, Matti Hamalainen wrote:
> On Mon, 10 Aug 2009, Kostya wrote:
> 
> > On Mon, Aug 10, 2009 at 12:37:30PM +0300, Matti Hamalainen wrote:
> > > 
> > > As in $subj.
> >  
> > Hmm, I don't understand why you skip ID3 data, then return to it again
> > and parse. Maybe simply parse without skipping?
> 
> Well, I thought about that first, but then I considered that skipping may 
> be faster way to see if it is an MPC file (some ID3v2 tags can be 
> absolutely huge). But I don't really have any hard data to back this up,
> so I can change this if you wish.

Sounds reasonable, applied as is.



More information about the ffmpeg-devel mailing list