[FFmpeg-devel] [PATCH][RFC] Lagarith Decoder.

Måns Rullgård mans
Wed Aug 12 19:47:15 CEST 2009


Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Wed, Aug 12, 2009 at 05:10:36PM +0100, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> 
>> > On Wed, Aug 12, 2009 at 04:12:25PM +0100, M?ns Rullg?rd wrote:
>> >> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> >> 
>> >> > Well, you still have to teach the compiler at least to use clz for
>> >> > av_log2, I think you haven't yet ;-)
>> >> 
>> >> I can't because it's in common.h, which is installed.  We really
>> >> should find a way to fix that.
>> >
>> > Just put the optimizations under HAVE_AV_CONFIG_H like everything else
>> > in there that is messy?
>> 
>> And keep adding to the mess?  That's not the way to do things.
>
> Then how about adding a new internal header with that function and

Or use an existing one.

> putting the version in the installed header under
> #ifndef HAVE_AV_CONFIG_H
> i.e. just to keep API compatibility?
> Possibly even deprecating that version?
> Would that be clean enough?

Better, but it doesn't feel quite right.  I guess we don't have much
other choice though.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list