[FFmpeg-devel] [PATCH] Core Audio Format demuxer (v3)

[Diego Biurrun]

On Sat, Aug 15, 2009 at 05:35:42PM +1000, Peter Ross wrote:
> 
> Revised patch enclosed.

.. some nitpicks ..

> --- /dev/null
> +++ b/libavformat/caf.c
> @@ -0,0 +1,58 @@
> +
> +/**
> + * Known codec tags for caf

nit: CAF

> +  /* FIXME: use dv demuxer, as done in mov */

nit: DV, MOV

> --- /dev/null
> +++ b/libavformat/cafdec.c
> @@ -0,0 +1,427 @@
> +
> +    int64_t packet_cnt;             ///< packet counter. used during demuxing.
> +    int64_t frame_cnt;              ///< frame counter. used during demuxing.

s/.//

> +static int read_kuki_chunk(AVFormatContext *s, int64_t size)
> +{
> +    ByteIOContext *pb = s->pb;
> +    AVStream *st = s->streams[0];

align

> +    caf->num_frames  = get_be64(pb);  /* valid frames */
> +    caf->num_frames += get_be32(pb); /* priming frames */
> +    caf->num_frames += get_be32(pb); /* remainder frames */

comment ASCII art? :)

> +        case MKBETAG('d','a','t','a'):
> +            url_fskip(pb, 4); /* edit count */
> +            caf->data_start = url_ftell(pb);
> +            caf->data_size = size-4;

align, spaces around '-'

Diego