[FFmpeg-devel] [PATCH]RTSP Basic Authentication

[Ronald S. Bultje]

Hi,

On Mon, Jul 27, 2009 at 5:26 PM, Ronald S. Bultje<rsbultje at gmail.com> wrote:
> On Mon, Jul 27, 2009 at 5:11 PM, Benoit Fouet<benoit.fouet at free.fr> wrote:
>> you can remove the '!= NULL'
> [..]
>> it may just be me, but I would find it easier to read if auth definition
>> was at the end of the line.
> [..]
>> 'if (auth[0])' or even 'if (*auth)'
>> that would be consistent with how it is initialized in url_split()
> [..]
>> this is never freed
> [..]
>> s/strlen(auth)/auth_len/
> [..]
>
> Holy shit I suck today. New patch attached that fixes them all. Thanks
> for your review. :-).

Ping? In particular, Luca B, could you review this?

Thanks,
Ronald