[FFmpeg-devel] [PATCH] ALS decoder

[Thilo Borgmann]

>> I think he means, what is rlslms?
> 
> exactly and sorry for beig unclear
> 
> 
>> So your comment should say Recursive Least Square-Least Mean Square
>> instead of RLS-LMS.
> 
> ok, iam not entirely sure what it is from that term but i canguess the
> direction i guess ...
Ok.


> i see, still at least the declarations could be moved in the loop
Ok.

> and f course if something can be done about the 64bit that would be great
> speedwise ...
Unfortunately, the reference decoder also uses 64-bit for them.


>>>>> +        if (sconf->resolution == 2 || sconf->floating)
>>>>> +            const_val_bits = 24;
>>>>> +        else
>>>>> +            const_val_bits = avctx->bits_per_raw_sample;
>>>> why would const_val_bits != avctx->bits_per_raw_sample ?
>>> bits_per_raw_sample = 32 for floating sconf->floating.
>> To explain this further... The way floating-point in ALS works is that
>> it has a 24-bit integer part and a floating-point difference part.  So
>> the final output is 32-bit, even though the integer part decoded here is
>> only 24-bit.
> 
> the sconf->resolution == 2 still is useless?
The output format in that case is also set to SAMPLE_FMT_S32.

-Thilo