[FFmpeg-devel] [PATCH] ALS decoder

[Thilo Borgmann]

Herv? W. schrieb:
>>>> +    int aux_data_enabled;     ///< indicates that auxiliary data is present
>>>> +    int chan_config_info;     ///< mapping of channels to loudspeaker locations
>>> never read
>> But a TODO is set to use it in a future release.
> 
> I think the guideline is: don't add it until you need it.
> Unless you can guarantee that you'll be around to implement that TODO.
> 
>>>> +    int *chan_pos;            ///< original channel positions
>>> same
>> Same.
>> Do these hurd so much it has to be reinserted later?
> 
> Does it hurt so much to reinsert them later?


Michael Niedermayer schrieb:
> On Sun, Aug 23, 2009 at 12:47:49AM +0200, Herv? W. wrote:
>> Comments are inline. (My use of "perhaps" is not sarcasm or something).
>>
>> 2009/8/22 Thilo Borgmann <thilo.borgmann at googlemail.com>:
> [...]
>>>>> +    int aux_data_enabled;     ///< indicates that auxiliary data
is present
>>>>> +    int chan_config_info;     ///< mapping of channels to
loudspeaker locations
>>>> never read
>>> But a TODO is set to use it in a future release.
>> I think the guideline is: don't add it until you need it.
>> Unless you can guarantee that you'll be around to implement that TODO.
>
> or add a "unused currently will be used once foobar is implemenetd"


Ok I added a "unused" to the comment. And yes, I will be around to
implement this later on.
And removing it completely will most likely cause to forget about it as
there are many thing in the queue about the decoder.

So there is a TODO and a "unused" comment for the time being, if that
pleases everyone?

-Thilo