[FFmpeg-devel] [PATCH] Core Audio Format demuxer

[Baptiste Coudurier]

Hi Peter,

On 08/10/2009 04:13 AM, Peter Ross wrote:
> On Sun, Aug 09, 2009 at 03:40:28PM -0700, Baptiste Coudurier wrote:
>> Hi Peter,
>>
>> First, thanks a lot for doing this.
>>
>> On 8/9/2009 2:41 AM, Peter Ross wrote:
>>> [...]
>>>
>>>        get_be32(pb); /* version + flags */
>>> -    len = mp4_read_descr(c, pb,&tag);
>>> +    len = mp4_read_descr(fc, pb,&tag);
>> Take the opportunity to add a space here, before&  :)
>>
>>>        if (tag == MP4ESDescrTag) {
>>>            get_be16(pb); /* ID */
>>>            get_byte(pb); /* priority */
>>>        } else
>>>            get_be16(pb); /* ID */
>>>
>>> -    len = mp4_read_descr(c, pb,&tag);
>>> +    len = mp4_read_descr(fc, pb,&tag);
>> Same.
>>
>>>        if (tag == MP4DecConfigDescrTag) {
>>>            int object_type_id = get_byte(pb);
>>>            get_byte(pb); /* stream type */
>>> @@ -419,10 +419,10 @@ static int mov_read_esds(MOVContext *c, ByteIOContext *pb, MOVAtom atom)
>>>            get_be32(pb); /* avg bitrate */
>>>
>>>            st->codec->codec_id= ff_codec_get_id(ff_mp4_obj_type, object_type_id);
>>> -        dprintf(c->fc, "esds object type id %d\n", object_type_id);
>>> -        len = mp4_read_descr(c, pb,&tag);
>>> +        dprintf(fc, "esds object type id %d\n", object_type_id);
>>> +        len = mp4_read_descr(fc, pb,&tag);
>> Ditto.
>
> Um, i dont see any of these "mp4_read_descr(fc, pb,&tag)" problems in the original patch...

Humm, ok then my mailer has some display problems I guess. Sorry for the 
confusion.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org