[FFmpeg-devel] [PATCH] Speex parser

[Michael Niedermayer]

On Sun, Aug 30, 2009 at 05:49:56PM -0400, Justin Ruggles wrote:
> Michael Niedermayer wrote:
> 
> > On Sun, Aug 30, 2009 at 10:40:45AM -0400, Justin Ruggles wrote:
> >> Hi,
> >>
> >> Here is a Speex parser.  It does not split any frames, but only analyzes
> >> them in order to set the proper AVCodecContext parameters.
> > 
> > the decoder can do this, av_find_stream_info() should already create a
> > decoder to fill these in when they are missing.
> 
> Why should it have to rely on the decoder...

because it works and needs 0 lines of code compared to your quite large
patch


> especially since we do not
> have a native decoder?  So that one MUST compile in an external library
> for stream copy to work properly.

do we want a native decoder or an external dependancy?
either way these parameters seem best be read in the decoder ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090831/97531056/attachment.pgp>