No subject

[bogus at does.not.exist.com]

equal to the last granulepos (0 in the case of the first page), and any
subsequent packets in the page will have os->lastgp == -1.

>> +        /* first packet */
>> +        os->pduration = os->granule + spxp->frame_size *  
>> frames_per_packet *
>> +                        (1 - ogg_page_packets(os));
> 
> granule - frame_size * frames_per_packet * (ogg_page_packets(os) - 1)  
> and likewise for last_packet_duration is more clear IMO, since it's  
> equivalent to (stream duration including packet) - (stream duration  
> excluding packet).

ok. fixed.

new patch attached.

Thanks,
Justin


--------------090603030409040706000009
Content-Type: text/x-diff;
 name="speex_granulepos_delay_3.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="speex_granulepos_delay_3.patch"

diff --git a/libavformat/oggdec.c b/libavformat/oggdec.c
index adf0ad0..129268b 100644
--- a/libavformat/oggdec.c
+++ b/libavformat/oggdec.c
@@ -380,6 +380,7 @@ ogg_packet (AVFormatContext * s, int *str, int *dstart, int *dsize)
 
     if (os->header > -1 && os->seq > os->header){
         os->pflags = 0;
+        os->pduration = 0;
         if (os->codec && os->codec->packet)
             os->codec->packet (s, idx);
         if (str)
@@ -524,6 +525,7 @@ ogg_read_packet (AVFormatContext * s, AVPacket * pkt)
     }
 
     pkt->flags = os->pflags;
+    pkt->duration = os->pduration;
 
     return psize;
 }
diff --git a/libavformat/oggdec.h b/libavformat/oggdec.h
index 91a5974..cefde7e 100644
--- a/libavformat/oggdec.h
+++ b/libavformat/oggdec.h
@@ -50,6 +50,7 @@ struct ogg_stream {
     unsigned int pstart;
     unsigned int psize;
     unsigned int pflags;
+    unsigned int pduration;
     uint32_t serial;
     uint32_t seq;
     uint64_t granule, lastgp;
diff --git a/libavformat/oggparsespeex.c b/libavformat/oggparsespeex.c
index cc00dd2..31f8b1d 100644
--- a/libavformat/oggparsespeex.c
+++ b/libavformat/oggparsespeex.c
@@ -30,12 +30,22 @@
 #include "avformat.h"
 #include "oggdec.h"
 
+struct speex_params {
+    int final_packet_duration;
+};
+
 static int speex_header(AVFormatContext *s, int idx) {
     struct ogg *ogg = s->priv_data;
     struct ogg_stream *os = ogg->streams + idx;
+    struct speex_params *spxp = os->private;
     AVStream *st = s->streams[idx];
     uint8_t *p = os->buf + os->pstart;
 
+    if (!spxp) {
+        spxp = av_mallocz(sizeof(*spxp));
+        os->private = spxp;
+    }
+
     if (os->seq > 1)
         return 0;
 
@@ -69,8 +79,47 @@ static int speex_header(AVFormatContext *s, int idx) {
     return 1;
 }
 
+static int ogg_page_packets(struct ogg_stream *os)
+{
+    int i;
+    int packets = 0;
+    for (i = 0; i < os->nsegs; i++)
+        if (os->segments[i] < 255)
+            packets++;
+    return packets;
+}
+
+static int speex_packet(AVFormatContext *s, int idx)
+{
+    struct ogg *ogg = s->priv_data;
+    struct ogg_stream *os = ogg->streams + idx;
+    struct speex_params *spxp = os->private;
+    int packet_size = s->streams[idx]->codec->frame_size;
+
+    if (os->flags & OGG_FLAG_EOS && os->lastgp != -1 && os->granule > 0) {
+        /* first packet of final page. we have to calculate the final packet
+           duration here because it is the only place we know the next-to-last
+           granule position. */
+        spxp->final_packet_duration = os->granule - (os->lastgp -
+                                      packet_size * (ogg_page_packets(os) - 1));
+    }
+
+    if (!os->lastgp && os->granule > 0)
+        /* first packet */
+        os->pduration = os->granule - packet_size * (ogg_page_packets(os) - 1);
+    else if (os->flags & OGG_FLAG_EOS && os->segp == os->nsegs &&
+             spxp->final_packet_duration)
+        /* final packet */
+        os->pduration = spxp->final_packet_duration;
+    else
+        os->pduration = packet_size;
+
+    return 0;
+}
+
 const struct ogg_codec ff_speex_codec = {
     .magic = "Speex   ",
     .magicsize = 8,
-    .header = speex_header
+    .header = speex_header,
+    .packet = speex_packet
 };

--------------090603030409040706000009--