[FFmpeg-devel] [PATCH] Add pad filter

[Vitor Sessak]

Stefano Sabatini wrote:
> On date Monday 2009-11-30 20:18:35 +0100, Michael Niedermayer encoded:
>> On Mon, Nov 30, 2009 at 09:17:18AM +0100, Stefano Sabatini wrote:
>>> On date Monday 2009-11-30 01:28:41 +0100, Michael Niedermayer encoded:
> [...]
>>>> i think the code is too complex and messy now for what it does.
>>>> Also it now partly duplicates slicify 
>>> What about to issue just a single slice for the top and bottom bars?
>> ok
> 
> Simplified.

Just a nit:

> +static int query_formats(AVFilterContext *ctx)
> +{
> +    enum PixelFormat pix_fmts[] = {
> +        PIX_FMT_ARGB,         PIX_FMT_RGBA,
> +        PIX_FMT_ABGR,         PIX_FMT_BGRA,
> +        PIX_FMT_RGB24,        PIX_FMT_BGR24,
> +
> +        PIX_FMT_YUV444P,      PIX_FMT_YUV422P,
> +        PIX_FMT_YUV420P,      PIX_FMT_YUV411P,
> +        PIX_FMT_YUV410P,      PIX_FMT_YUV440P,
> +        PIX_FMT_YUVJ444P,     PIX_FMT_YUVJ422P,
> +        PIX_FMT_YUVJ420P,     PIX_FMT_YUVJ440P,
> +        PIX_FMT_YUVA420P,
> +
> +        PIX_FMT_NONE
> +    };

This array can be a static const, no?

-Vitor