[FFmpeg-devel] [PATCH 5/6] RTMP output: implement rtmp-output

[Sergiy]

2009/12/4 Kostya <kostya.shishkov at gmail.com>:

> braces, please (in all such places)
added.

> obviously
> ?if(!t && !strcmp("NetStream.Play.Start")) rt->state = STATE_PLAYING;
> ?if(!t && !strcmp("NetStream.Publish.Start")) rt->state =
> STATE_PUBLISHING;
>
> what you did is semantically wrong

changed.
"return 0" removed too, because rtmp_parse_result() returns 0.

> Again, this seems like unneeded condition. Probably you just forget to
> send rt->flv_data = NULL along with rt->flv_size = 0.

Fixed.
But setting rt->flv_size to 0 is not necessary.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rtmp-output.patch
Type: text/x-diff
Size: 15579 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091204/551d5298/attachment.patch>