[FFmpeg-devel] [PATCH] x4->params.analyse.b_weighted_bipred gets wrong bool value in libx264.c

[Erik Slagter]

On zo, 2009-12-06 at 12:00 +0000, Loren Merritt wrote:

> > I am not sure about the _exact_ semantics of this field, but according
> > to the source of x264 and compare runs it seems that value of this field
> > must be either 0 or 1, and not 0 or 32 what ffmpeg uses. A shallow
> > glance at the code inside libx264 suggests it does make a difference to
> > use 32 or 1 for true, so I'd rather have it correct.
> 
> If a boolean field in x264.h acts differently depending on which true 
> value you give it, that's a bug in libx264. However, that does not appear 
> to be the case here. I just tried it, and weightb=32 does the same as 
> weightb=1.

I probably grepped for the wrong field, can't find it anymore, sorry for
the fuss.

Anyway, can't it be applied as "cosmetic" sort of patch, because the
value in de parameter dump at the start of the output indeed says 32
while actually means 1, which makes it a little bit harder to compare
with the output of the dump of a x264 run.