[FFmpeg-devel] [PATCH] Add pad filter

[Stefano Sabatini]

On date Saturday 2009-12-12 18:43:00 +0100, Michael Niedermayer encoded:
> On Sat, Dec 12, 2009 at 03:14:40PM +0100, Stefano Sabatini wrote:
> > On date Tuesday 2009-12-08 13:42:01 +0100, Stefano Sabatini encoded:
> > > On date Tuesday 2009-12-08 03:01:04 +0100, Michael Niedermayer encoded:
> [...]
> > > > but i think there might be another problem that will need fixing,
> > > > are data[x] aligned to 16 bytes? because some optimized filters will
> > > > need them aligned and id guess pad & crop can produce non aligned cases.
> > > > so possibly we need a AV_PERM_ALIGNED that ensures maximum alignment the
> > > > cpu might need initiating a copy of the frame if its insfficiently aligned.
> > 
> > Ping+patch for the pad filter updated.
> 
> read above, there is a problem in the pad and crop filters.

You / anyone never talked about optimized filters which require
aligned data, if we keep adding requirements each day lavfi won't
never end-up integrated into the main repo, especially considering
that I'm doing the coding work almost alone.
 
> Besides this, we need regression tests for the filters, i plan to make
> this mandatory for every new filter now, too many bugs sliped through
> already.
> No reg test for a filter -> no approval.

That's resonable, OK, but this needs a more thorough discussion on how
to design a more complete test system, I'll do that in a more
pertinent thread.

Regards.
-- 
FFmpeg = Fostering and Frightening Martial Plastic Erroneous Gymnast