[FFmpeg-devel] [PATCH] Use symbolic names for PAL/NTSC rather than numeric constants in ffmpeg.c:opt_target

[Michael Niedermayer]

On Sun, Dec 13, 2009 at 04:31:51PM +0100, Stefano Sabatini wrote:
> Hi, as in subject, improve readability.
> -- 
> FFmpeg = Fierce & Friendly Mastodontic Programmable Epic Generator

>  ffmpeg.c |   33 +++++++++++++++++----------------
>  1 file changed, 17 insertions(+), 16 deletions(-)
> 65a70f82a8b3a2dc7cfb61d2e7f1d387f93da6ce  ffmpeg-use-symbol-for-pal-ntsc.patch
> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 20821)
> +++ ffmpeg.c	(working copy)
> @@ -3598,26 +3598,27 @@
>  
>  static void opt_target(const char *arg)
>  {
> +    enum { PAL, NTSC, FILM };

>      int norm = -1;

should be enum not int except that this is a nice improvment and ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091213/0cabe0cf/attachment.pgp>