[FFmpeg-devel] [PATCH 2/2] Add SIPR decoder for 5k0, 6k5 and 8k5 modes

[Vitor Sessak]

Diego Biurrun wrote:
> On Fri, Dec 18, 2009 at 05:52:13PM +0100, Vitor Sessak wrote:
>> --- libavcodec/sipr.c	(revision 0)
>> +++ libavcodec/sipr.c	(revision 0)
>> @@ -0,0 +1,611 @@
>> +typedef struct
>> +{
> 
> { on the same line

fixed

>> +            ff_celp_lp_synthesis_filterf(
>> +                ctx->postfilter_syn5k0 + LP_FILTER_ORDER + i*subsize,
>> +                pAz, excitation, L_SUBFR_SIPR, LP_FILTER_ORDER);
> 
> ugly formatting

What do you suggest? Splitting the sum in two lines or passing the 
80-char limit?

>> +            float energy = ff_dot_productf(
>> +                ctx->postfilter_syn5k0 + LP_FILTER_ORDER + i * subsize,
>> +                ctx->postfilter_syn5k0 + LP_FILTER_ORDER + i * subsize,
>> +                L_SUBFR_SIPR);
> 
> again

same

>> +    ff_acelp_apply_order_2_transfer_function(
>> +        synth,
>> +        (const float[2])  {-1.99997   , 1.},
>> +        (const float[2])  {-1.93307352, 0.935891986},
>> +        0.939805806, ctx->ymem, frame_size);
> 
> ditto

Gave a try to a different formatting.

Here is a new patch with these and a few other minor cosmetics fixed.

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_sipr2_2.diff
Type: text/x-patch
Size: 39413 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091218/b5c20ee5/attachment.bin>